Heck I was still using my 2012 Macbook Air until pretty recently, a decent machine if you don't mind that it gets really hot under load.
Barring any major fiascos (like past keyboard issues), the 2021 MBP does look built to last. We're in a good spot now in terms of stuff like a great screen (if you don't need constant 120Hz), low-power video decoding, a solid 8-core CPU, and probably even a passable gaming GPU. Should remain very usable even as it's outclassed in subsequent generations.
My MacBook Pro from 2012 (the one without Retina display and had an optical drive too which I replaced with a secondary SSD) lasted me over 8 years. It finally overheated during summer (my house was very hot and fans were probably clogged). I do iOS and Android app development, so that $1000 device made me tons of money in return.
Same with my MBA 2012. Works great. Will get an M1 something or other and pass the MBA on to my daughter. If I get approx 10 years out of the M1?, I’m happy.
Even if you depreciate at $1000k/year, that's not too bad for a professional tool. It's not worth $0 after 4 years either.